Enable order page in the core #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Progi1984 merged 17 commits into PrestaShop:main from nesrineabdmouleh:migrateOrderPage

May 22, 2024

Contributor

nesrineabdmouleh commented May 21, 2024

Questions	Answers
Description?	Enable order page in the core
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?
Sponsor company	https://github.com/PrestaShopCorp
How to test?	CI is 🍏

nesrineabdmouleh added 2 commits

May 21, 2024 16:21


          Add data for order page

437aa14


          Enable the page order

38404b9

nesrineabdmouleh marked this pull request as draft

May 21, 2024 14:24


          Add blanc line in the end

22bde14

nesrineabdmouleh marked this pull request as ready for review

May 21, 2024 14:32

nesrineabdmouleh requested a review from Progi1984

May 21, 2024 14:32

Progi1984 reviewed

View reviewed changes

src/pages/BO/orders/view/productsBlock.ts Outdated Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/pages/BO/orders/view/viewOrderBasePage.ts Outdated Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

Member

Progi1984 left a comment

2 another small feedbacks

nesrineabdmouleh added 3 commits

May 21, 2024 16:48


          Update src/index

3cd3699


          Fix demo order data

3625ff7


          Fix review

3d89023

Progi1984 reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

Member

Progi1984 left a comment

A feedback

nesrineabdmouleh added 2 commits

May 21, 2024 17:03


          Fix review

65f7910


          Fix typo

c4da800

nesrineabdmouleh requested a review from Progi1984

May 21, 2024 15:15

Progi1984 reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/pages/BO/orders/view/productsBlock.ts Outdated Show resolved Hide resolved

nesrineabdmouleh added 3 commits

May 21, 2024 17:30


          Fix lint errors

f634c88


          Fix review

03cfd9d


          Fix review

52505dd

Progi1984 reviewed

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

Progi1984 added TE E2E Tests labels

nesrineabdmouleh added 5 commits

May 22, 2024 10:39


          Add product faker file

e867eeb


          Add interfaces

1a81d7e


          Fix review

51b1dbf


          Fix lint errors

39998b4


          Fix lint errors

5d5be36

Progi1984 approved these changes

View reviewed changes

Progi1984 reviewed

View reviewed changes

src/index.ts Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/interfaces/BO/orders/index.ts Outdated Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/interfaces/BO/orders/index.ts Outdated Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/interfaces/BO/orders/view/productsBlock.ts Outdated Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/interfaces/BO/orders/view/productsBlock.ts Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/interfaces/BO/orders/view/viewOrderBasePage.ts Show resolved Hide resolved

Progi1984 reviewed

View reviewed changes

src/versions/develop/pages/BO/orders/index.ts Outdated Show resolved Hide resolved


          Fix review

acde8c9

Progi1984 approved these changes

View reviewed changes

Progi1984 merged commit 61d8bee into PrestaShop:main

2 checks passed

nesrineabdmouleh deleted the migrateOrderPage branch

May 22, 2024 14:19

Progi1984 added this to the 0.0.12 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels